146.xdg open bug #148
Merged
146.xdg open bug #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #146 wherein
xdg-opensubprocess calls will fail to launch the user-specified file-manager under frozen/PyInstaller builds on Linux. As it turns out, the PyInstaller bootloader sets aLD_LIBRARY_PATHenvironment variable on Linux which, for whatever reason, interferes withxdg-open's ability to locate and/or launch the desktop file-manager. Unsetting this environment variable, accordingly, corrects this behavior, allowing the file-manager to launch as expected.