138.filesystem lock #141
Merged
138.filesystem lock #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this can't be relied upon for cleanup; acquire should not rely on the lockfile not existing
Otherwise, the destination directory of the lockfile may not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix/workaround for the issue described in #138: rather than listening on port 52045 to provide a quick-and-dirty interprocess mutex that works across platforms, this PR instead leverages the python standard library's
fcntl.flock()to provide a filesystem-based exclusive locking mechanism on UNIX-like systems (falling back to keeping an open file descriptor on Windows to provide similar -- but not wholly equivalent -- functionality), thereby preventing the situation in which Gridsync would sometimes erroneously throw a user-facing "Gridsync is already running" error message on certain macOS Mojave configurations (caused, it seems, from security/sandbox policies that might prevent listening/binding on ports).