Fix "shared" folder emblems #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the "shared" status of a given folder is determined. More specifically, it changes the MagicFolderChecker class/QObject to emit a
members_updatedsignal (replacingmember_added,member_removed) which passes a list of currently known members to the folder statusModelclass. TheModel, in turn, updates the UI to display the "shared" emblem/overlay if the list contains more than one member and removes it (thus setting the status to "private") if it contains only one. Previously, theModeltracked membership numbers by way of an integer mapped to each folder name, however this was mistakenly being incremented too often (specifically, when re-scanning a remote folder after it had been removed/deactivated) and was never decremented (thus the status would be displayed as "shared" even if all other members get manually removed from the magic-folder DMD). Passing the full list of currently known members thus helps to ensure that membership information is accurately reflected in the UI and will make it easier, in the future, to perform other membership-related operations from theModelclass (like fetching/viewing member "profiles" or removing members from a folder).