Skip to content

"Invite" improvements #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwood merged 67 commits into from
Jan 10, 2019
Merged

"Invite" improvements #129

crwood merged 67 commits into from
Jan 10, 2019

Conversation

@crwood
Copy link
Member

@crwood crwood commented Jan 10, 2019

This PR consists of a number of minor improvements to "invite"-related UI elements and their underlying code, including:

  • Wrapping lower-level Wormhole and SetupReceiver methods/signals into higher-level "InviteSender" and "InviteReceiver" QObject classes
  • Adding in-app "help" buttons/dialogs on invite-code widgets, explaining "invite codes" and "Tor network" to users
  • Fixing some font and UI clipping/overlapping issues observed on macOS and Windows
  • Adding "shared" status indicators (overlay icons, tooltips) to remote folders
  • Adjusting stylesheets and error dialog text
  • Removing the need to restart Gridsync in order to see new grids added via the "Enter Code" dialog
  • Displaying service provider icons if/when received via the "Enter Code" dialog
  • Prompting for additional user-confirmation when enabling Tor from the welcome screen or "Enter Code" dialogs

crwood added 30 commits December 3, 2018 13:19
@crwood
Move lower-level functionality to invite.py (WIP)
8a1baad
@crwood
Move/update invite tests
c8fa315
@crwood
Add explanatory/help button to "invite code" label
737af2e
@crwood
Update invite code info text
8ff2d3c 
Thanks JP! :)
@crwood
Fix whitespaces; appease flake8/pylint
0a1acf2
@crwood
Dynamically fade Tor checkbox in/out
c65ecab
@crwood
Update Tor checkbox test
0175b4b
@crwood
Adjust fixedSize for info buttons on macOS
5c02fd3 
Otherwise it gets clipped, for some reason
@crwood
Set name from APP_NAME constant in Tor info text
e8304e8
@crwood
Update Tor info text; italicize
e7e0b2a
@crwood
Add extra space on macOS to prevent overlap
aa2a2f3
@crwood
Update attribute name
8da65c0
@crwood
Cleanup
fecb1f7
@crwood
Move Preferences button into sub layout
abff488 
This fixes overlap issues caused by very low screen resolutions and/or
high global UI scaling settings on Windows
@crwood
Update Tor documentation
a551b6f
@crwood
Use InviteCodeWidget in InviteReceiver dialog
3b51b83
@crwood
Cleanup
0cd0bd9
@crwood
Rename: "InviteReceiver" -> "InviteReceiverDialog"
57f3477
@crwood
Only emit grid_already_joined signal if no folders
a0e002e
@crwood
Replace SetupRunner, Wormhole with InviteReceiver
8b3c7f2
@crwood
Add InviteReceiver.cancel method
7d85d7d
@crwood
Fix grid_already_joined pyqtSignal test
e48671e
@crwood
Re-order MainWindow toolbar widgets
136d874
@crwood
Fix dimensions of 'invite.png'; add top border
3684628
@crwood
Rename variables: 'pair_widget' -> 'share_widget'
17fb2d7
@crwood
Pass selected folders to ShareWidget
324144f
@crwood
Update folder icon overlay for shared folders
e0c3c9f
@crwood
Fallback to gray icon for pathless/remote folders
a693823
@crwood
Add folder name to tooltip for remote-only folders
fc3c76a
@crwood
Formatting
528788b
crwood added 28 commits January 8, 2019 12:42
@crwood
Smoothen Tor onion pixmap when scaling
b48e501
@crwood
Dampen color of "question" image/icon
810ba40
@crwood
Merge branch 'master' into invite-improvements
5d6824f
@crwood
Appease pylint/flake8; fix indentation
8d808ff
@crwood
Update info boxes; use setInformativeText on macOS
0d5c3e5
@crwood
Ensure green checkmark is shown on done
3c3ac25
@crwood
Remove intermediate variables
a37c162
@crwood
Cleanup
c7f1a59
@crwood
Use TOR_PURPLE color constant for QProgressBar
814ecb3
@crwood
Reorganize some attributes..
6d6486d
@crwood
Restore failure handler
d9e37dc
@crwood
Restore receive cancel timer
f46d919
@crwood
Cleanup
4e2865e
@crwood
Don't load recovery keys doc URL from config.txt
c97da2d
@crwood
Remove recovery_url from config.txt
35a7d26
@crwood
Rename: "ShareWidget" -> "InviteSenderDialog"
329932e
@crwood
Adjust "question" image/icon color
cc872ed
@crwood
Only show folder icon if folders were joined
7c46cdf
@crwood
Remove Windows scaling workaround/hack
59574b2
@crwood
Remove 'noqa' pragma statement/comment
7b9b681
@crwood
Update signal forwards; remove unused pyqtSignals
0fa1bbd
@crwood
Cleanup; remove superfluous set_status_shared call
4ab9283
@crwood
Display service provider icon if/when received
c8d66a7
@crwood
Reconnect Tor checkbox signal/slot
eaf2cf3
@crwood
Restore missing Tor label
6f936e3
@crwood
Adjust size of Tor "onion" pixmap/icon
05d1c5d
@crwood
Warn, prompt for confirmation when enabling Tor
c057eb1
@crwood
Always verify tor checkbox state before proceeding
b4e2b12
@crwood crwood merged commit 30003ce into master Jan 10, 2019
@crwood crwood deleted the invite-improvements branch January 10, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crwood