Skip to content

Renamed resizestop event name on API docs#978

Closed
fedesnieg wants to merge 1 commit into
gridstack:developfrom
fedesnieg:develop
Closed

Renamed resizestop event name on API docs#978
fedesnieg wants to merge 1 commit into
gridstack:developfrom
fedesnieg:develop

Conversation

@fedesnieg

Copy link
Copy Markdown

The event name was wrong on the API docs. The correct event name is resizestop

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 65.23% when pulling 9b68d8e on fedesnieg:develop into 590bc34 on gridstack:develop.

@adumesny

Copy link
Copy Markdown
Member

No it is not named wrong (maybe 'resizedone' would been clearer?) - see #398
gs has to have a custom event that is guaranteed to be AFTER the normal resizestop event sent in which we update our sizes, otherwise you might get called first. I'll update the doc.

@adumesny adumesny mentioned this pull request Mar 29, 2019
@radiolips

Copy link
Copy Markdown
Member

Thanks for pointing this out, @fedesnieg , and thanks @adumesny for taking care of updating the docs.

@radiolips radiolips closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants