Skip to content

#757 Fixed returning of an array of actually changed widgets#789

Closed
vadus1 wants to merge 1 commit into
gridstack:developfrom
vadus1:develop
Closed

#757 Fixed returning of an array of actually changed widgets#789
vadus1 wants to merge 1 commit into
gridstack:developfrom
vadus1:develop

Conversation

@vadus1

@vadus1 vadus1 commented Sep 19, 2017

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 69.59% when pulling be25e42 on vadus1:develop into 57c6511 on gridstack:develop.

@radiolips

Copy link
Copy Markdown
Member

@vadus1 What's this fix?

@adumesny

adumesny commented Dec 17, 2019

Copy link
Copy Markdown
Member

this is NOT the right fix, because if you temporally move other objects out while dragging one, they will not return to original position (_dirty from _origY will be FALSE, so new GridStackEngine() onChange() callback will not be called to do a self._updateStyles(maxHeight + 10); on line 784

what we actually need is store the original X/Y/W/H and compare in _triggerChangeEvent() rather than just check for _dirty flag

@adumesny adumesny closed this Dec 17, 2019
@adumesny adumesny mentioned this pull request Dec 17, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants