Skip to content

nested grid save inf loop fix#1863

Merged
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master
Oct 3, 2021
Merged

nested grid save inf loop fix#1863
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master

Conversation

@adumesny

@adumesny adumesny commented Oct 3, 2021

Copy link
Copy Markdown
Member

Description

fix #1860 which was caused by #1793

  • cloneDeep() will now skip clonning internal known objects we don't serialize (and delete later with removeInternalAndSame())

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

fix gridstack#1860 which was caused by gridstack#1793
* cloneDeep() will now skip clonning internal known objects we don't serialize (and delete later with removeInternalAndSame())
@adumesny adumesny merged commit c9fd294 into gridstack:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Error On Save]: Uncaught RangeError: Maximum call stack size exceeded

1 participant