fix nested grids with different acceptWidgets class#1150
Merged
Conversation
* fix for #1143 * added sample test where parent and nested grid have different drop class support * while this.dd.droppable.accept() does check for el.is(self.opts.acceptWidgets === true ? '.grid-stack-item' : self.opts.acceptWidgets) to prevent wrong items from being dropped, the problem was that `dropover|dropout|drop` handlers did NOT return false so the parent grid was getting them as well, causing error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the problem was that
dropover|dropout|drophandlers did NOT return false (was handled) so the parent grid was getting the bubbled event, causing errorChecklist
yarn test)