Skip to content

optimized change callback#1148

Merged
adumesny merged 1 commit into
gridstack:developfrom
adumesny:develop
Feb 16, 2020
Merged

optimized change callback#1148
adumesny merged 1 commit into
gridstack:developfrom
adumesny:develop

Conversation

@adumesny

@adumesny adumesny commented Feb 16, 2020

Copy link
Copy Markdown
Member

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

optimized change callback
920195a 
* save original x,y,w,h values and only call those that changed
(and not just tempory flag _dirty)
* getting all the test cases was tricky. Used all demos with some mods.
* related to #1147 which fixes #1142
@coveralls

coveralls commented Feb 16, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.4%) to 68.247% when pulling 920195a on adumesny:develop into e660480 on gridstack:develop.

@adumesny adumesny merged commit b30655d into gridstack:develop Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RemoveWidget() doesn't also trigger change events when it should

2 participants

@adumesny @coveralls