Skip to content

Advanced demo page added#1067

Closed
DigitalJo wants to merge 1 commit into
gridstack:developfrom
DigitalJo:demo-contribution
Closed

Advanced demo page added#1067
DigitalJo wants to merge 1 commit into
gridstack:developfrom
DigitalJo:demo-contribution

Conversation

@DigitalJo

Copy link
Copy Markdown

I''ve added a new page on the demo folder with the advanced example of the gridstack website

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 66.758% when pulling b886b2d on DigitalJo:demo-contribution into 0258954 on gridstack:develop.

@adumesny

Copy link
Copy Markdown
Member

@DigitalJo thanks for doing this, but it looks like you copied the entire runtime DOM instead of the source code - way to much HTML stuff. Also in the demo/ folder I've been using src relative files (since it helps us debug the code we write). Also data-gs-width="12" is old, and data-gs-column=12 is not needed (default).

If you want to check it in (and I think it's a good idea as it's different from two.html, I would switch to to the hg-pages branch and copy it out of index.html (the website landing page). You'll need to copy it somewhere before switching back to develop as they don't share any files.
I would rather have you get the credit for submit, else i can do it.

@DigitalJo

Copy link
Copy Markdown
Author

u copied the entire runtime DOM instead of the source code - way to much HTML stuff. Also in the demo/ folder I've been using src relative files (since it helps us debug the code we write). Also data-gs-width="12" is old, and data-gs-column=12 is not needed (default).

If you want to check it in (and I think it's a good idea as it's different from two.html, I would switch to to the hg-pages branch and copy it out of index.html (the website landing page). You'll need to copy it somewhere before switching back to develop as they don't share any files.
I would rather have you get the credit for submit, else i can do it.

thank you very much for your feedback.I will check it as soon as possible

@adumesny

Copy link
Copy Markdown
Member

I ended up checking one in for ya... thanks for the work!

@adumesny adumesny closed this Nov 26, 2019
@DigitalJo DigitalJo deleted the demo-contribution branch November 26, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants