addWidget(el, options) with object param#1038
Merged
Merged
Conversation
* new addWidget(el, options) to pass object so you don't have to spell 10 params * updated TS file, test case, some samples
creage
reviewed
Nov 14, 2019
| GridStack.prototype.addWidget = function(el, x, y, width, height, autoPosition, minWidth, maxWidth, minHeight, maxHeight, id) { | ||
|
|
||
| // instead of passing all the params, the user might pass an object with all fields instead, if so extract them and call us back | ||
| if (typeof x === 'object') { |
There was a problem hiding this comment.
this will fail if we pass null as a value of x, as typeof null === 'object' returns true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix for #907
Checklist
yarn test)