Skip to content

Commit e3329ad

Browse files
committed
trigger only one event for removeAll()
1 parent c1c4ff8 commit e3329ad

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

src/gridstack.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,8 +1288,9 @@
12881288
return this.grid.canBePlacedWithRespectToHeight(node);
12891289
};
12901290

1291-
GridStack.prototype.removeWidget = function(el, detachNode) {
1291+
GridStack.prototype.removeWidget = function(el, detachNode, triggerEvents) {
12921292
detachNode = typeof detachNode === 'undefined' ? true : detachNode;
1293+
triggerEvents = typeof detachNode === 'undefined' ? true : triggerEvents;
12931294
el = $(el);
12941295
var node = el.data('_gridstack_node');
12951296

@@ -1304,16 +1305,21 @@
13041305
if (detachNode) {
13051306
el.remove();
13061307
}
1307-
this._triggerChangeEvent(true);
1308-
this._triggerRemoveEvent();
1308+
if (triggerEvents) {
1309+
this._triggerChangeEvent(true);
1310+
this._triggerRemoveEvent();
1311+
}
13091312
};
13101313

13111314
GridStack.prototype.removeAll = function(detachNode) {
13121315
_.each(this.grid.nodes, _.bind(function(node) {
1313-
this.removeWidget(node.el, detachNode);
1316+
this.removeWidget(node.el, detachNode, false);
13141317
}, this));
13151318
this.grid.nodes = [];
13161319
this._updateContainerHeight();
1320+
1321+
this._triggerChangeEvent(true);
1322+
this._triggerRemoveEvent();
13171323
};
13181324

13191325
GridStack.prototype.destroy = function(detachGrid) {

0 commit comments

Comments
 (0)