Merged
Conversation
Contributor
Author
|
hmm, my unit test and shfmt tests works locally, But it does not work in the CI/CD pipeline. I will try later this week troubleshoot why it is the case. |
Contributor
Author
|
All dependencies should now have been secured. Running the command locally provides me no hint to what is needed @greymd If you can assist that would be greatly helpful, other than that I now believe its ready to reviewed. Thanks :) |
Owner
Oh really, ok I am taking a look.. |
greymd
reviewed
Apr 24, 2023
Contributor
Author
|
Thanks @greymd, I have now applied the docker container to my workflow instead of running it locally. All checks should now be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing xpns_log()
This will replace following functions
This will consolidate our code and make it easier as its all in one function.
Features
loglevels is now called via an positional argument, eg:
xpns_log "error" "${_dir} is not writable."we now have following values we can call:
New look to the logoutput
It now comes with a new updated output to improve readability
old vs new
xpanes:Info: This is an info messagexpanes:Debug: [2023-04-18_15:24:33]:main:debug example[xpanes:info] This is an info message[xpanes:debug:2023-04-18_15:24:33:main] debug exampleAbility to parse multiple inputs
old function had the limitations to only parse the first positional argument it acquired. With xpns_log we can make how many arguments we wish.
For example:
old and new
xpns_msg_info "this is an info message" "and here is more information"xpns_log "info" "This is an info message" "and here is more information"this provides following input:
old
xpanes:Info: this is an info messagenew
[xpanes:info] This is an info message and here is more informationI have tested the function on all the input in xpanes, but should we ever get an issue with parsing the loglevel, we have a following output:
[xpanes:internal error] invalid log type, if you get this error. Please file an issue on github: https://github.com/greymd/tmux-xpanes/issuesReferring to setup an issue on the project if it ever occurs.
I have also made unit testing for the function to make sure we catch any issues.
Cheers