Merge all option sanitation functions into xpns_opt_checker()#190
Merged
greymd merged 5 commits intogreymd:masterfrom Apr 16, 2023
Merged
Merge all option sanitation functions into xpns_opt_checker()#190greymd merged 5 commits intogreymd:masterfrom
greymd merged 5 commits intogreymd:masterfrom
Conversation
Owner
|
Nice. This PR will be merged in the next few days. |
Contributor
Author
|
Great addition, If I get time I will take a look if we can create more unit tests for it. |
Contributor
Author
|
in 0b220f3 I solidified the integer regex, this to make sure that we do not get weird behavior if people are applying floats or multiple dots to the options that expect integers. I have added these cases as test as well, combined with one for csv if the beginning is correct but wrong format comes later in the csv. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we remove four of the sanitation functions, to instead have a single main function for this purpose.
We are by default expecting an integer, if not an integer we are utilizing an additional positional parameters such as "csv" "string" or "float", which then changes the _pattern variable (except for string where we check if its populated).
With this change we can now scale much better and has the ability to add additional option sanitation checks easily with just another elif case.