Merged
Conversation
Contributor
Author
|
Looks like its not working as expected, I will look into this later this week. |
greymd
reviewed
Apr 5, 2023
Contributor
Author
|
I found the issue, me preventing globbing and word splitting with double quotation marks made my input not work correctly. |
Owner
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling global ${TMUX_XPANES_EXEC} multiple times, we combine the layout commands into a single local$layout_command string variable and execute it in a single call to $ {TMUX_XPANES_EXEC} at the end of the script.
This can should save some overhead and improve readability.
Since ${_args_num} is an integer, it is more efficient to use arithmetic evaluation with (( )) instead of the [[ ]] test operator. So I have changed it to (( _args_num > 1 )).
Please have a look at the commit and make sure its working as intended.
Cheers