Optimize xpns_log_filenames & xpns_arr2args functions#182
Merged
greymd merged 2 commits intogreymd:masterfrom Apr 1, 2023
Merged
Optimize xpns_log_filenames & xpns_arr2args functions#182greymd merged 2 commits intogreymd:masterfrom
greymd merged 2 commits intogreymd:masterfrom
Conversation
Contributor
Author
|
to clarify, with preliminary testing I mean checking that the sed works and that smoke screen tests went green. |
shfmt -i 2 -ci -sr -kp -d -w ./bin/xpanes
Owner
|
looks good. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this patch we optimize xpns_log_filenames to not spawn another sed process while being ran.
also optimizing xpns_arr2args using a more more efficient syntax for iterating over the array, this is done by using _arg in "$@" directly instead of declaring _arg="${i}" every loop. As well as optimizing sed usage.
I have done some preliminary testing making sure that its working as expected, but I have not compiled and ran it. Please have a look before merging
Thanks for a great tool, cheers.