Nameserver information to network block#2058
Merged
bim9262 merged 8 commits intogreshake:masterfrom Jun 19, 2024
Merged
Conversation
bim9262
reviewed
Jun 4, 2024
Contributor
Author
|
Should I squash the commits into a single one or it is fine the way it is? |
Collaborator
I usually do "squash and merge", so no need to do it manually. |
Contributor
|
Looks like this breaks the [[block]]
block = "net"
device = "wlp3s0"
format = "$icon $signal_strength $speed_down $graph_down $speed_up $graph_up $frequency"
missing_format = "no net"
[[block]]
block = "net"
device = "enp2s0f0"
format = " $speed_down $graph_down $speed_up $graph_up"I only get "Failed to read nameservers" twice with this. |
Collaborator
|
@matthiaskrgr can you share the output of |
Contributor
|
Collaborator
|
Hmm, we currently don't handle the |
Contributor
Collaborator
|
I mean in the context of resolv.conf. Is it that this nameserver is interface-specific? |
Collaborator
Now tracked in #2080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first implementation to add more information to the network block.
The previous discussion was held in the following issue #2053. Specifically the first step of reading the
nameserverssaved inetc/resolv.conf.It files that are modified are
netlinks.rsandnet.rs. With the former being the one that changes the most by creating a function to read the file, modify the Device struct and the last file by updating the documentation and adding the information to be displayed.