Chang UINT64 amounts to base 10 display#35
Merged
gregtatcam merged 7 commits intogregtatcam:feature/mpt-v1from Sep 19, 2024
Merged
Chang UINT64 amounts to base 10 display#35gregtatcam merged 7 commits intogregtatcam:feature/mpt-v1from
gregtatcam merged 7 commits intogregtatcam:feature/mpt-v1from
Conversation
gregtatcam
reviewed
Sep 16, 2024
| return str; | ||
| }; | ||
|
|
||
| if (auto const& fName = getFName(); fName == sfMaximumAmount || |
Owner
There was a problem hiding this comment.
Doesn't feel right having ST* types having knowledge of specific fields. Is it the only way?
Author
There was a problem hiding this comment.
STUInt16 has something similar, so i think this is fine
Json::Value STUInt16::getJson(JsonOptions) const
{
if (getFName() == sfLedgerEntryType)
{
auto item = LedgerFormats::getInstance().findByType(
safe_cast<LedgerEntryType>(value_));
if (item != nullptr)
return item->getName();
}
|
|
||
| std::uint64_t val; | ||
|
|
||
| bool const useBase10 = field == sfMaximumAmount || |
Owner
There was a problem hiding this comment.
Same - generic type has knowledge of specific fields.
| struct MPTCreate | ||
| { | ||
| std::optional<std::int64_t> maxAmt = std::nullopt; | ||
| std::optional<std::string> maxAmt = std::nullopt; |
Owner
There was a problem hiding this comment.
Do we need to change the type? Can just change when the value is formatted to the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)