Skip to content

Upcoming Release Changes#585

Merged
ardatan merged 1 commit intomainfrom
changeset-release/main
Feb 4, 2025
Merged

Upcoming Release Changes#585
ardatan merged 1 commit intomainfrom
changeset-release/main

Conversation

@theguild-bot
Copy link
Copy Markdown
Collaborator

@theguild-bot theguild-bot commented Feb 4, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@graphql-tools/executor-graphql-ws@2.0.1

Patch Changes

  • #591 7d42160 Thanks @ardatan! - Fix the regression preventing users from passing custom lazy and lazyCloseTimeout options

@graphql-hive/gateway@1.9.3

Patch Changes

  • Updated dependencies [7d42160, 7d42160]:
    • @graphql-mesh/transport-ws@1.0.1

@graphql-mesh/transport-ws@1.0.1

Patch Changes

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-graphql-ws 2.0.1-rc-53ea0f645a6b4bd4b6b072ba2a5cc7ee6496764e npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.9.3-rc-53ea0f645a6b4bd4b6b072ba2a5cc7ee6496764e npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-ws 1.0.1-rc-53ea0f645a6b4bd4b6b072ba2a5cc7ee6496764e npm ↗︎ unpkg ↗︎

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 4, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue in the GraphQL WS executor that restored support for custom lazy configuration options.
  • Chores

    • Updated package versions: GraphQL WS executor upgraded to v2.0.1, GraphQL Hive gateway to v1.9.3, and WebSocket transport to v1.0.1.
    • Optimized the WebSocket transport by removing an unnecessary dependency and refining client instantiation.

Walkthrough

This pull request updates three packages. In the executor package, the version is bumped to 2.0.1 with a patch fix that restores support for passing custom lazy and lazyCloseTimeout options, along with migration guidance to graphql-ws v6. The gateway package is updated to version 1.9.3 with a dependency bump for @graphql-mesh/transport-ws. The transport package is updated to version 1.0.1, which removes the isomorphic-ws dependency, updates the executor dependency to 2.0.1, and improves client instantiation by avoiding redundant initialization.

Changes

File(s) Change Summary
packages/executors/graphql-ws/CHANGELOG.md, packages/executors/graphql-ws/package.json Bumped version to 2.0.1; fixed regression that prevented usage of custom lazy and lazyCloseTimeout options; noted migration to graphql-ws v6.
packages/gateway/CHANGELOG.md, packages/gateway/package.json Bumped version to 1.9.3; updated dependency @graphql-mesh/transport-ws from 1.0.0 to 1.0.1.
packages/transports/ws/CHANGELOG.md, packages/transports/ws/package.json Bumped version to 1.0.1; removed the isomorphic-ws dependency; updated dependency @graphql-tools/executor-graphql-ws from 2.0.0 to 2.0.1; optimized client instantiation.

Possibly related PRs

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0761af and 53ea0f6.

📒 Files selected for processing (6)
  • packages/executors/graphql-ws/CHANGELOG.md (1 hunks)
  • packages/executors/graphql-ws/package.json (1 hunks)
  • packages/gateway/CHANGELOG.md (1 hunks)
  • packages/gateway/package.json (1 hunks)
  • packages/transports/ws/CHANGELOG.md (1 hunks)
  • packages/transports/ws/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (6)
  • packages/executors/graphql-ws/package.json
  • packages/gateway/package.json
  • packages/transports/ws/package.json
  • packages/transports/ws/CHANGELOG.md
  • packages/executors/graphql-ws/CHANGELOG.md
  • packages/gateway/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (21)
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: Unit / Bun
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Snapshot / snapshot
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Missing peer deps
  • GitHub Check: Leaks / Node v22
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: Leaks / Node v20
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Bundle
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Benchmark / node / 10 items

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/plugins/prometheus/CHANGELOG.md (1)

15-2770: Changelog History Consistency & Formatting

The remainder of the changelog presents the historical release notes in a clear, chronologically descending order. Each version header is consistently formatted with a clear separation between “Patch Changes” and “Minor Changes” where applicable, and commit links and references are provided throughout. This overall structure helps maintain clarity for anyone reviewing the release history.

One minor suggestion would be to consider whether very old version entries might be archived or summarized if the file grows excessively long; however, this is an optional improvement and not a strict requirement.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53a8ac2 and e0761af.

📒 Files selected for processing (20)
  • .changeset/@graphql-hive_gateway-421-dependencies.md (0 hunks)
  • .changeset/@graphql-hive_gateway-runtime-421-dependencies.md (0 hunks)
  • .changeset/@graphql-mesh_fusion-runtime-421-dependencies.md (0 hunks)
  • .changeset/@graphql-mesh_plugin-prometheus-421-dependencies.md (0 hunks)
  • .changeset/@graphql-mesh_transport-ws-421-dependencies.md (0 hunks)
  • .changeset/@graphql-tools_executor-graphql-ws-421-dependencies.md (0 hunks)
  • packages/executors/graphql-ws/CHANGELOG.md (1 hunks)
  • packages/executors/graphql-ws/package.json (1 hunks)
  • packages/fusion-runtime/CHANGELOG.md (1 hunks)
  • packages/fusion-runtime/package.json (1 hunks)
  • packages/gateway/CHANGELOG.md (1 hunks)
  • packages/gateway/package.json (1 hunks)
  • packages/plugins/opentelemetry/CHANGELOG.md (1 hunks)
  • packages/plugins/opentelemetry/package.json (1 hunks)
  • packages/plugins/prometheus/CHANGELOG.md (1 hunks)
  • packages/plugins/prometheus/package.json (1 hunks)
  • packages/runtime/CHANGELOG.md (1 hunks)
  • packages/runtime/package.json (1 hunks)
  • packages/transports/ws/CHANGELOG.md (1 hunks)
  • packages/transports/ws/package.json (1 hunks)
💤 Files with no reviewable changes (6)
  • .changeset/@graphql-mesh_fusion-runtime-421-dependencies.md
  • .changeset/@graphql-hive_gateway-421-dependencies.md
  • .changeset/@graphql-mesh_transport-ws-421-dependencies.md
  • .changeset/@graphql-tools_executor-graphql-ws-421-dependencies.md
  • .changeset/@graphql-hive_gateway-runtime-421-dependencies.md
  • .changeset/@graphql-mesh_plugin-prometheus-421-dependencies.md
✅ Files skipped from review due to trivial changes (13)
  • packages/executors/graphql-ws/package.json
  • packages/gateway/package.json
  • packages/plugins/prometheus/package.json
  • packages/runtime/package.json
  • packages/fusion-runtime/package.json
  • packages/transports/ws/package.json
  • packages/fusion-runtime/CHANGELOG.md
  • packages/gateway/CHANGELOG.md
  • packages/executors/graphql-ws/CHANGELOG.md
  • packages/plugins/opentelemetry/CHANGELOG.md
  • packages/plugins/opentelemetry/package.json
  • packages/transports/ws/CHANGELOG.md
  • packages/runtime/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/plugins/prometheus/CHANGELOG.md (3)

Pattern packages/**: In this directory we keep all packages relevant to the gateway.

In most cases, when changes are made to the source code / dependencies in these directories, we also require to have a corresponding changeset file, created using yarn changeset with a full description on the changes with an example.
Also, when new features are added the packages, the changeset file should mention minor semver change. When a bug is fixed, patch needs to be used. The major bump is used for a PR that has breaking changes.


Pattern packages/plugins/**: The directories inside this dir are gateway plugins. Plugins adds functionality to the GraphQL gateway, at the runtime level. Plugins included are authorization, authentication, caching, persisted documents and more.


Pattern **: For all PRs, we would like to verify that a Linear issue is linked. Check if there's a mention for "GW-*" in the PR description, and the us know when it's missing.

In most cases, when a PR adds a new functionality, we would like to make sure it has documentation in the corresponding console project.
Use the global knowledge feature to search for PRs in graphql-hive/console repository that adds documentation. Suggest to create a follow up issue to add the missing documentation.

⏰ Context from checks skipped due to timeout of 90000ms (27)
  • GitHub Check: Binary built on ubuntu-24.04-arm
  • GitHub Check: Bun Docker image
  • GitHub Check: Binary built on windows-latest
  • GitHub Check: Node Docker image
  • GitHub Check: Binary built on macos-14
  • GitHub Check: Binary built on macos-13
  • GitHub Check: Binary built on ubuntu-latest
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: Leaks / Node v22
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: Leaks / Node v20
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Build
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Bundle
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Mend Security Check
🔇 Additional comments (1)
packages/plugins/prometheus/CHANGELOG.md (1)

1-14: New Release Version 1.3.28: Dependency Updates

This new version block clearly documents the latest patch release for the Prometheus plugin. It shows that the graphql-yoga peer dependency has been updated from ^5.10.6 to ^5.10.11 and that @graphql-hive/gateway-runtime has been bumped from 1.4.11 to 1.4.12. The commit reference (#421) and commit hash are properly included, and the credit to Renovate is appropriately given. The description is concise and adheres to the expected changelog format.

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.9.3-rc-53ea0f645a6b4bd4b6b072ba2a5cc7ee6496764e-bun

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.9.3-rc-53ea0f645a6b4bd4b6b072ba2a5cc7ee6496764e

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Copy Markdown
Collaborator Author

theguild-bot commented Feb 4, 2025

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants