Skip to content

Conversation

@Shane32
Copy link
Member

@Shane32 Shane32 commented Jan 23, 2024

Requires GraphQL.NET 8.x

Other changes required since extension methods were moved from IProvideMetadata to IMetadataReader in v8.

Tests not finished yet

@Shane32 Shane32 self-assigned this Jan 23, 2024
@Shane32 Shane32 changed the base branch from master to develop August 3, 2024 15:49
@Shane32 Shane32 changed the title [WIP] Add attribute for media type validation Add attribute for media type validation Aug 3, 2024
@Shane32 Shane32 added this to the 8.0 milestone Aug 3, 2024
@Shane32 Shane32 requested a review from gao-artur August 3, 2024 16:10
@Shane32 Shane32 added the enhancement New feature or request label Aug 3, 2024
Comment on lines +94 to +98
foreach (var validMediaType in _mediaTypes)
{
if (mediaType.IsSubsetOf(validMediaType))
return;
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Where

This foreach loop [implicitly filters its target sequence](1) - consider filtering the sequence explicitly using '.Where(...)'.
var operations = new
{
query = "mutation ($img: FormFile!) { rotate(file: $img) }",
variables = new { img = (string?)null },

Check warning

Code scanning / CodeQL

Useless upcast

There is no need to upcast from [null](1) to [String](2) - the conversion can be done implicitly.
@Shane32 Shane32 merged commit c421048 into develop Aug 3, 2024
@Shane32 Shane32 deleted the attr branch August 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants