Limits errors in getVariableValues()#2062
Conversation
| /** | ||
| * Coerces a JavaScript value given a GraphQL Input Type. | ||
| */ | ||
| export function coerceInputValue( |
There was a problem hiding this comment.
I decided to create a new coerceInputValue function sine coerceValue is part of public API so we can't change its behavior.
In addition to that the new name is less confusing since GraphQL Spec defines Input coercion and Result coercion:
https://graphql.github.io/graphql-spec/draft/#sec-Scalars.Input-Coercion
|
It's draft PR (I still need to work on tests) but it would be great to get feedback on a new @SoyYoRafa @Cito Can you please take a look? |
ae9e34b to
44adfee
Compare
|
I took a look after the fact, looks good. I thought about doing a similar thing but since I am not a maintainer, I didn't want to just rewrite parts of the code. |
|
@SoyYoRafa Thanks for the review 👍 |
Based on #2037