fix(tap-agent): use unique sender ID in metrics cleanup test#913
Merged
suchapalaver merged 1 commit intomainfrom Jan 28, 2026
Merged
fix(tap-agent): use unique sender ID in metrics cleanup test#913suchapalaver merged 1 commit intomainfrom
suchapalaver merged 1 commit intomainfrom
Conversation
da5f56e to
0e71d29
Compare
The test_sender_level_gauges_cleanup_on_post_stop test was flaky because it used a shared sender ID (SENDER.1) for Prometheus metrics while tests run in parallel. Parallel tests using the same sender label could interfere with each other's metric values. Changes: - Add optional sender_id parameter to create_sender_account test helper - Return sender_id from create_sender_account for tests to use - Update the flaky test to use Address::random() for test isolation - Update all call sites to handle the new 6-element return tuple Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
0e71d29 to
40cf5bb
Compare
Pull Request Test Coverage Report for Build 21420819108Details
💛 - Coveralls |
suchapalaver
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky test
test_sender_level_gauges_cleanup_on_post_stopby using a unique sender ID for test isolation.Problem
The test was non-deterministic because:
SENDER.1) for Prometheus metricsSolution
sender_idparameter tocreate_sender_accounttest helpersender_idfromcreate_sender_accountfor tests to useAddress::random()for test isolation🤖 Generated with Claude Code