fix: Prevent GraphQL query bypass and add service provider validation#898
Merged
fix: Prevent GraphQL query bypass and add service provider validation#898
Conversation
Add a 4KB size limit check for status queries before parsing to prevent memory exhaustion attacks from large malicious queries. Part of TRST-H-2 security fix for GraphQL allowlist bypass.
…[TRST-H-2] The /status endpoint's field allowlist could be bypassed by hiding forbidden fields inside inline fragments or named fragment spreads. The validation only checked Selection::Field, ignoring InlineFragment and FragmentSpread variants entirely. Changes: - Add recursive field extraction that traverses all selection types - Implement circular fragment detection to prevent infinite loops - Add depth limit (10) to prevent stack overflow from deep nesting
Pull Request Test Coverage Report for Build 20962336225Details
💛 - Coveralls |
suchapalaver
previously approved these changes
Jan 13, 2026
suchapalaver
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses security vulnerabilities in the status endpoint and adds service provider validation for TAP receipts.
Changes
Status endpoint hardening (status.rs)