Bump existing grammar versions#39
Merged
grantjenks merged 9 commits intograntjenks:mainfrom Jan 24, 2024
Merged
Conversation
5a7bea4 to
9324d40
Compare
Contributor
Author
|
@grantjenks Any thoughts on this PR 🙏🏼? |
Contributor
Author
|
Interesting seg fault with Python 3.6 in the Ubuntu OS 🤔 I wonder if we should drop support for 3.6 and 3.7 since they are already EOF (https://endoflife.date/python). WDYT @grantjenks? |
Contributor
Author
|
@grantjenks could you help to kick of the CI build, please? 🙏🏼 |
6c0c52a to
dac3d42
Compare
Both versions are already EOF.
dac3d42 to
dea2a4f
Compare
PHP grammar has been split since tree-sitter/tree-sitter-php#192 and 'vendor/tree-sitter-php/src/parser.c' no longer exists.
64be101 to
65dbab2
Compare
One the grammar is causing segmentation fault in the build.
Contributor
Author
|
@grantjenks This PR is now ready for review 🙏🏼 |
Owner
|
Can we keep 3.7 support? Otherwise looks good. |
Contributor
Author
Yep. Totally. Addressed in c82123e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hcl,mitchellh/tree-sitter-hcl->MichaHoffmann/tree-sitter-hclerlang,AbstractMachinesLab/tree-sitter-erlang->WhatsApp/tree-sitter-erlang