Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Add derivative and nonNegativeDerivative functions#996

Merged
Dieterbe merged 3 commits intografana:masterfrom
bloomberg:nonNegativeDerivative
Aug 15, 2018
Merged

Add derivative and nonNegativeDerivative functions#996
Dieterbe merged 3 commits intografana:masterfrom
bloomberg:nonNegativeDerivative

Conversation

@stivenbb
Copy link
Copy Markdown
Contributor

@stivenbb stivenbb commented Aug 14, 2018

Native implementation of derivative() and nonNegativeDerivative() Graphite functions.

@Dieterbe Dieterbe self-requested a review August 15, 2018 09:46
}

func (s *FuncDerivative) Context(context Context) Context {
return context
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, i had originally envisioned the context mechanism to allow things like getting an earlier point by adjusting the from query time, so that we can start off our first point with a valid one instead of NaN. but that infrastructure isn't quite place yet, and graphite doesn't try to be this fancy anyway, so we can leave this as is. and maybe someday revisit.

@Dieterbe Dieterbe merged commit edbf319 into grafana:master Aug 15, 2018
@shanson7 shanson7 deleted the nonNegativeDerivative branch August 21, 2018 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants