Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Revert "fix tests"#990

Merged
Dieterbe merged 4 commits intomasterfrom
re-instance-unused-etc
Aug 15, 2018
Merged

Revert "fix tests"#990
Dieterbe merged 4 commits intomasterfrom
re-instance-unused-etc

Conversation

@Dieterbe
Copy link
Copy Markdown
Contributor

This reverts commit 5dfee57.

@replay
Copy link
Copy Markdown
Contributor

replay commented Aug 13, 2018

@Dieterbe IIRC the problem with these tests was that some external dependency was broken. We can either wait until it is fixed and then add the tests back, or fork the dependency and fix it ourselves.

@Dieterbe
Copy link
Copy Markdown
Contributor Author

@Dieterbe
Copy link
Copy Markdown
Contributor Author

our invocation style was wrong, works now.

@Dieterbe Dieterbe merged commit 347a051 into master Aug 15, 2018
@Dieterbe Dieterbe deleted the re-instance-unused-etc branch September 18, 2018 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants