Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Fix http4608#987

Merged
Dieterbe merged 3 commits intografana:masterfrom
bloomberg:fixHttp4608
Aug 15, 2018
Merged

Fix http4608#987
Dieterbe merged 3 commits intografana:masterfrom
bloomberg:fixHttp4608

Conversation

@shanson7
Copy link
Copy Markdown
Collaborator

@shanson7 shanson7 commented Aug 9, 2018

Workaround for #984

@Dieterbe
Copy link
Copy Markdown
Contributor

my concern here is that this reduces our ability to diagnose and resolve the real issue.
maybe we should log warnings at least.

@shanson7
Copy link
Copy Markdown
Collaborator Author

That sounds reasonable. Would you want a stack trace of the current goroutine?

@Dieterbe
Copy link
Copy Markdown
Contributor

good idea. warn + dump stack dump is useful.
can you explain though, while >599 is clearly theoretically incorrect, what's the practical problem you're seeing caused by this?

@shanson7
Copy link
Copy Markdown
Collaborator Author

Basically, users see "cluster node unavailable" rather than a possibly useful error and I have to dig through logs to figure out what actually happened.

@Dieterbe Dieterbe self-requested a review August 15, 2018 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants