Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

set jaeger-client-go source path and updates vendor#934

Merged
Dieterbe merged 1 commit intomasterfrom
jaegerImportPath
Jun 7, 2018
Merged

set jaeger-client-go source path and updates vendor#934
Dieterbe merged 1 commit intomasterfrom
jaegerImportPath

Conversation

@woodsaj
Copy link
Copy Markdown
Contributor

@woodsaj woodsaj commented Jun 7, 2018

fixes #933

@woodsaj woodsaj requested a review from Dieterbe June 7, 2018 02:52
@woodsaj
Copy link
Copy Markdown
Contributor Author

woodsaj commented Jun 7, 2018

@Dieterbe when running dep ensure a huge number of new packages have been added to the vendor dir. the diff of Gopkg.lock shows only the intended changes so i am not sure why all of these packages are now needed, or were they just missing previously.

Also running dep ensure removes all of the local changes to gopkg.in/raintank/schema.v1, so i guess we have not merged the schema changes uptream? if that is the case, we should get that done

@Dieterbe
Copy link
Copy Markdown
Contributor

Dieterbe commented Jun 7, 2018

I have just merged the schema changes raintank/schema#18
we should probably tag this as v2.0 and then it'll be available on gopkg.in as v2 right?

dep is a bit strange. the recent versions of dep are supposed to automatically prune when you run ensure, however I always run dep prune after dep ensure because it usually finds things to clean up, also in this case it worked for me and removed all the extra stuff,
except for some the schema changes which should be fixed once we tag it I think.

go get -u github.com/golang/dep/cmd/dep
dep ensure
dep prune

@woodsaj woodsaj force-pushed the jaegerImportPath branch from 21d0a7d to 6fddb7c Compare June 7, 2018 17:30
@woodsaj
Copy link
Copy Markdown
Contributor Author

woodsaj commented Jun 7, 2018

we should probably tag this as v2.0 and then it'll be available on gopkg.in as v2 right?

probably, but lets move that discussion to the raintank/schema repo

@Dieterbe Dieterbe merged commit c9375bf into master Jun 7, 2018
@Dieterbe Dieterbe deleted the jaegerImportPath branch September 18, 2018 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cant run dep ensure due to uber/jaeger-tracing no longer existing

2 participants