This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Merged
Conversation
should result in memory savings in the index when loading for cassandra, if <0 -> assign OrgIdPublic
replay
reviewed
Apr 12, 2018
| } | ||
| org, err := strconv.Atoi(orgStr) | ||
| if err != nil { | ||
| if err != nil || org < 1 { |
Contributor
There was a problem hiding this comment.
now the public org id is configurable, right? so if somebody sets it to a high value, would 0 as an actual non-public org id be invalid?
Contributor
Author
There was a problem hiding this comment.
this is for authentication. when authenticating as an org-id, the org id must be >= 1 otherwise it is invalid.
this was true when public org id was -1, and remains true now that public org id can be any value >=1
(you would typically not specify the public org id for authentication, but rather a concrete, real org id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this helps us save some memory.
math.MaxUint32 == 4294967295
I don't anticipate we will ever have more orgs than that.
when loading from cassandra, if <0 -> assign OrgIdPublic