This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Update profiletrigger: switch from vsz to rss and add threshold for heap as well#1914
Merged
Update profiletrigger: switch from vsz to rss and add threshold for heap as well#1914
Conversation
484f0d4 to
2b28318
Compare
* old version used to look at Memstats.Sys, which was the entire virtual memory space, and effectively useless. Hence also why it's been hidden in the dashboard since forever. Most people expect this would look effectively at rss, so that's what we do now. + optional parameter to look at (only) the heap specifically * change default collection interval to 10s. That's what we've been running in prod for years without any issues.
2b28318 to
d4d8971
Compare
shanson7
reviewed
Oct 2, 2020
robert-milan
suggested changes
Oct 13, 2020
Contributor
robert-milan
left a comment
There was a problem hiding this comment.
Just the change for clarification already noted, other than that looks fine, but I haven't reviewed the library code from profiletrigger so I am unaware of all those changes. Would you like me to take a look at those?
Contributor
Author
nah those went through review already in that repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memory space, and effectively useless. Hence also why it's been hidden
in the dashboard since forever. Most people expect this would
look effectively at rss, so that's what we do now. + optional
parameter to look at (only) the heap specifically
running in prod for years without any issues.