This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Dedup resolve series requests#1794
Merged
Dieterbe merged 3 commits intografana:masterfrom Apr 24, 2020
Merged
Conversation
replay
reviewed
Apr 23, 2020
Dieterbe
reviewed
Apr 24, 2020
Dieterbe
approved these changes
Apr 24, 2020
Contributor
|
looks great! thanks sean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty small change to reduce the number of round trips for requests that have duplicate metric pattern queries / seriesByTarget requests.
Looking at our logs for all of yesterday, my company sees that about 1/3 of all requests with 2 or more seriesByTag expressions have a duplicate.