This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Merged
Conversation
2187797 to
81d23db
Compare
Contributor
|
Should |
Contributor
Author
|
yes. actually we should probably grep around a bit more too. there might be some documentation talking about prometheus too, that we should clean up. and config files that may have settings about the prometheus input or query endpoint |
81a6612 to
d8d9043
Compare
d8d9043 to
50ba40c
Compare
Contributor
|
Think this is good to go aside from a changelog update |
Contributor
Author
|
looks great @fitzoh . unfortunately i can't approve this PR because it's my own :) |
fitzoh
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1454