Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Reject datapoints with timestamp too far in the future#1572

Merged
replay merged 8 commits intomasterfrom
limit_datapoints_with_future_ts
Dec 17, 2019
Merged

Reject datapoints with timestamp too far in the future#1572
replay merged 8 commits intomasterfrom
limit_datapoints_with_future_ts

Conversation

@replay
Copy link
Copy Markdown
Contributor

@replay replay commented Dec 12, 2019

Introduces a new setting called future-tolerance-ratio.
This is the implementation of what's described in this comment: #1560 (comment)

Fixes #1560

@Dieterbe
Copy link
Copy Markdown
Contributor

Do I understand this correctly?
if my schema is 1s:7d,1m:60d,30min:1y and future-tolerance-ratio = 10, this allows me to store points with ts upto now + 1y*10/100 so now + 36.5days. But this gets applied to all archives, so the raw data I send that has a TTL of 7d (but now gets a TTL of 43.5 days) ?

I thought this restriction would apply with respect to the TTL of the archive you're submitting to. (so if sending 1s data, it should only allow `now + 7d *10/100 ?

Comment thread mdata/aggmetrics.go Outdated
@replay replay force-pushed the limit_datapoints_with_future_ts branch from 946f31b to 9d5fbb2 Compare December 16, 2019 20:37
@replay replay force-pushed the limit_datapoints_with_future_ts branch from 9d5fbb2 to 12caf3e Compare December 16, 2019 20:42
Comment thread docker/docker-chaos/metrictank.ini
Comment thread mdata/aggmetric.go Outdated
Comment thread mdata/aggmetric.go
Copy link
Copy Markdown
Contributor

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@replay replay merged commit b88c3b8 into master Dec 17, 2019
@replay replay deleted the limit_datapoints_with_future_ts branch December 17, 2019 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When ingesting data from the future we use a TTL that's higher than the defined TTL

3 participants