Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Expr package: return proper errors upon bad request from user#1520

Merged
Dieterbe merged 4 commits intomasterfrom
expr-bad-request
Nov 5, 2019
Merged

Expr package: return proper errors upon bad request from user#1520
Dieterbe merged 4 commits intomasterfrom
expr-bad-request

Conversation

@Dieterbe
Copy link
Copy Markdown
Contributor

@Dieterbe Dieterbe commented Nov 4, 2019

fix #1462

package github.com/grafana/metrictank/api/response (test)
        imports github.com/grafana/metrictank/idx
        imports github.com/grafana/metrictank/expr/tagquery
        imports github.com/grafana/metrictank/api/response
FAIL    github.com/grafana/metrictank/api/response [setup failed]
@Dieterbe Dieterbe requested review from fkaleo and woodsaj November 4, 2019 21:43
Copy link
Copy Markdown
Contributor

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!!

@Dieterbe Dieterbe merged commit df69121 into master Nov 5, 2019
@Dieterbe Dieterbe deleted the expr-bad-request branch November 5, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve error handling in query pipeline to set proper http codes

2 participants