This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Don't validate MaxChunkSpan if BigTable store is disabled#1470
Merged
Dieterbe merged 1 commit intografana:masterfrom Sep 19, 2019
Merged
Don't validate MaxChunkSpan if BigTable store is disabled#1470Dieterbe merged 1 commit intografana:masterfrom
Dieterbe merged 1 commit intografana:masterfrom
Conversation
Hi, i'm using metrictank with cassandra as storage, but metrictank refues to start because of the default "max-chunkspan" is set too low. This means i have to adjust settings for a storage i'm not using. I would suggest to skip the validation of max-chunkspan if the bigtable store is not enabled.
Dieterbe
approved these changes
Sep 19, 2019
Contributor
Dieterbe
left a comment
There was a problem hiding this comment.
LGTM. thanks for taking the time to contribute back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i'm using metrictank with cassandra as storage, but metrictank refues to start because of the bigtable store setting "max-chunkspan" being set to low.
This means i have to adjust settings for a storage i'm not using.
I would suggest to skip the validation of max-chunkspan if the bigtable store is not enabled.