Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

make Find cache optional#1285

Merged
Dieterbe merged 2 commits intomasterfrom
find-cache-optional
Apr 17, 2019
Merged

make Find cache optional#1285
Dieterbe merged 2 commits intomasterfrom
find-cache-optional

Conversation

@Dieterbe
Copy link
Copy Markdown
Contributor

No description provided.

@Dieterbe Dieterbe force-pushed the find-cache-optional branch from 2574dea to a19bf85 Compare April 16, 2019 07:42
@Dieterbe Dieterbe requested a review from woodsaj April 16, 2019 07:42
@Dieterbe Dieterbe force-pushed the find-cache-optional branch 2 times, most recently from 6d74a80 to f3cbbb5 Compare April 16, 2019 07:56
@woodsaj
Copy link
Copy Markdown
Contributor

woodsaj commented Apr 16, 2019

wouldnt it be easier to just disable the findCache if find-cache-size is set to 0?

@Dieterbe
Copy link
Copy Markdown
Contributor Author

hmm yes. will update

@Dieterbe Dieterbe force-pushed the find-cache-optional branch from f3cbbb5 to b3728f0 Compare April 16, 2019 19:27
@Dieterbe
Copy link
Copy Markdown
Contributor Author

PTAL

Copy link
Copy Markdown
Contributor

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe Dieterbe merged commit 45405aa into master Apr 17, 2019
@woodsaj woodsaj deleted the find-cache-optional branch July 2, 2019 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants