Conversation
|
i ran benchmarks to try to find a performance impact, but there is none. only noise. https://snapshot.raintank.io/dashboard/snapshot/Q523wHqQ21IwSp9BygfxmSr34DwTxW9x?orgId=2 https://snapshot.raintank.io/dashboard/snapshot/FrXPzkYC6zGRTJJE7Eq4D8ECdkjArnvb?orgId=2 for completeness, i'll do another run with padded stats structs (to rule out false sharing), once i have time to leave my computer unattended. |
-> no gains |
so that they can't block each other
so that we can more easily re-use existing uint64's
no need for pointers
f3b117e to
9dd2b88
Compare
input/kafkamdm/kafkamdm.go
Outdated
| partitionOffsetMetric := partitionOffset[partition] | ||
| partitionLogSizeMetric := partitionLogSize[partition] | ||
| partitionLagMetric := partitionLag[partition] | ||
| kafkaStats := kafkaStats[partition] |
There was a problem hiding this comment.
detail: this could be initialized further down on :274 so we can save the allocation if there's an error in getting the offset
replay
left a comment
There was a problem hiding this comment.
LGTM with one last comment
cleaning up the code a bit in prep for #1022
TODO: same for metricpersist (maybe in a separate PR)