This repository was archived by the owner on Aug 23, 2023. It is now read-only.
notifier: deprecate NSQ ( rip :'( ) + add mt-kafka-persist-sniff tool#1161
Merged
notifier: deprecate NSQ ( rip :'( ) + add mt-kafka-persist-sniff tool#1161
Conversation
not to be confused with the previous type, which should just have been called Notifier. The goal is to not tightly couple the Notifier to the idx/metric, to enable upcoming tools to read the notifier data from kafka and print it
I love NSQ. But we haven't used it in a while so can't keep supporting it.
617a363 to
f8a0abd
Compare
f8a0abd to
f420a43
Compare
we lose ability to use config file / env vars, but we gain use of commandline flags and a help message that corresponds to it
7021069 to
048e1d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.