Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

mt-index-cat: make NameWithTags() callable from template format#1157

Merged
Dieterbe merged 4 commits intomasterfrom
make-pointer-methods-accessible
Dec 11, 2018
Merged

mt-index-cat: make NameWithTags() callable from template format#1157
Dieterbe merged 4 commits intomasterfrom
make-pointer-methods-accessible

Conversation

@Dieterbe
Copy link
Copy Markdown
Contributor

@Dieterbe Dieterbe commented Nov 30, 2018

NameWithTags has a pointer receiver
to see why we want this, open https://play.golang.org/p/OVfC4xQnZb4 and see the difference between passing a pointer vs a value.

@Dieterbe Dieterbe force-pushed the make-pointer-methods-accessible branch from 9b593e0 to 6df32d7 Compare November 30, 2018 22:34
Copy link
Copy Markdown
Contributor

@robert-milan robert-milan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Dieterbe Dieterbe merged commit 3acc3e5 into master Dec 11, 2018
@Dieterbe Dieterbe deleted the make-pointer-methods-accessible branch March 27, 2019 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants