This repository was archived by the owner on Aug 23, 2023. It is now read-only.
set sarama client KafkaVersion via config#1103
Merged
Conversation
see issue: #1053 from https://github.com/Shopify/sarama/blob/v1.19.0/config.go#L324-L330 ``` The version of Kafka that Sarama will assume it is running against. Defaults to the oldest supported stable version. Since Kafka provides backwards-compatibility, setting it to a version older than you have will not break anything, although it may prevent you from using the latest features. Setting it to a version greater than you are actually running may lead to random breakage. ```
5a7fba2 to
0feecad
Compare
Dieterbe
suggested changes
Oct 23, 2018
Contributor
Dieterbe
left a comment
There was a problem hiding this comment.
- seems like sarama supports any delimiter between the digits, so rather than underscores, let's use dots so that the strings are actual version strings.
- can we link or mention the supported ones? e.g. I notice there's a kafka release 1.1.1 for which there is no protocol version in sarama (even looking at latest master, which does support v2). this could be too much work to be worth it though.
Contributor
Author
this does appear to be true, but good catch. i just assumed that passing the supportVersion names would work, but ParseKafkaVersion actually wants the semver string. eg. for version <1.0 it is using the regex |
Contributor
Author
Sarama only uses the version number to determine what Kafka features it can use. It does this with calls like So the version provided doesn need to be in the list of supported versions. |
Contributor
Author
|
@Dieterbe this should be good now |
Dieterbe
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue: #1053
from https://github.com/Shopify/sarama/blob/v1.19.0/config.go#L324-L330