Conversation
idx/memory/tag_query.go
Outdated
| if equal < 0 { | ||
| corruptIndex.Inc() | ||
| log.Error(3, "memory-idx: ID %q has tag %q in index without '=' sign", def.Id, tag) | ||
| log.Errorf("ID %q has tag %q in index without '=' sign", def.Id, tag) |
There was a problem hiding this comment.
why are we no longer logging the component?
There was a problem hiding this comment.
we should be until we switch over to individual instances of logrus per module. It just looks like I forgot to place them back into that section, I'll fix it.
|
some notes on the output formats: tools:
|
|
can you compare benches before and after this change? |
|
I've been running benchmarks on master and this branch. I have disabled cpu frequency scaling and set my governor to performance, but I am still getting consistently inconsistent results specifically with the BenchmarkAggregate10k_* and BenchmarkGroupByTags10k_* series of benchmarks. Most of the other benchmarks are within tolerance of each other, but I am not very confident using the current numbers I have as a base for comparison. I am also receiving the same benchmarking failures on both branches. I have attached a zip of the results here. |
|
we haven't run the benchmarks in a while apparently, i didn't realize some of them are broken. to compare performance, will be most interesting to look at some methods that do a lot of Debug calls, especially those that have their LogLevel shields removed. e.g.
BenchmarkAggMetrics1000Metrics1Day
I don't have this issue. all benchmarks are within tolerance for me. in particular : edit looks like these tests need to be fixed |
|
with #1077 integrated in both master and this branch, I get: so a slight slowdown. no biggie |
remove old version of logrus (github.com/Sirupsen/logrus) add new version of logrus (github.com/sirupsen/logrus) lock logrus version to 1.0.6 add logger/logger.go for custom TextFormatter used with logrus
update documentation to match log-level change remove logging binary names
8db0e9a to
505f182
Compare
remove old version of logrus (github.com/Sirupsen/logrus)
add new version of logrus (github.com/sirupsen/logrus)
lock logrus version to 1.0.6
add logger/logger.go for custom TextFormatter used with logrus
first part of solving #624