This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Conversation
-> save disk space!
* use master for code that we can easily keep track of, is unlikely to break something, or should be upgraded (e.g. leveldb has received some bugfixes) * pin to whatever version or revision we were already using for the trickier dependencies
all users of upstream will have to start using dep or vgo or something, not gopkg.in
otherwise build failure
Merged
woodsaj
approved these changes
Aug 20, 2018
Contributor
woodsaj
left a comment
There was a problem hiding this comment.
one of the benefits of using gopkg.in is that you can import 2 different versions a package.
We have relied on this in the past to handle migration from one raintank/schema version to another.
So this might pose a problem in future, but hopefully by then Go supports versioning within the import statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.