This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Enable transport and client settings even in single mode#1000
Merged
Dieterbe merged 1 commit intografana:masterfrom Aug 21, 2018
Merged
Enable transport and client settings even in single mode#1000Dieterbe merged 1 commit intografana:masterfrom
Dieterbe merged 1 commit intografana:masterfrom
Conversation
Collaborator
Author
|
I was able to reproduce the crash, and can confirm that the above fixes it. I don't think there would be any large ramifications of instantiating the transport in single mode. |
|
Could this issue be addressed, pretty please? Thanks! |
Contributor
|
@deniszh sorry for the delay. i've decided to merge this PR but would still like to implement a more proper fix later. |
Dieterbe
approved these changes
Aug 21, 2018
Contributor
|
@deniszh please let us know how latest master works for you, thanks! |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requests are canceled, transport is used to cancel the downstream. This causes a panic in single mode because the transport is never instantiated.
Note that HTTP timeout must now be either blank or a valid value even in single mode.