Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2568 +/- ##
=======================================
Coverage 10.87% 10.87%
=======================================
Files 43 43
Lines 4130 4130
=======================================
Hits 449 449
Misses 3604 3604
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The new OBI version uses //go:embed exclusively to load the Java agent JAR at startup. The test Dockerfile was building Go first (embedding the placeholder), then copying the real JAR to /obi-java-agent.jar — a path the new runtime never reads — causing 'embedded OBI java agent artifact is missing' warnings and no Java TLS spans in all Java-agent tests. Fix mirrors OBI's own Dockerfile-with-javaagent: - Move javaagent-builder stage before the Go builder stage - COPY the Gradle-built JAR into vendor/go.opentelemetry.io/obi/pkg/internal/java/embedded/obi-java-agent.jar before make compile-for-coverage runs, so the real JAR is embedded at compile time - Remove the now-redundant final-stage COPY of the JAR to /obi-java-agent.jar Also update Makefile java-build / java-docker-build targets to output the JAR to the same vendor embed path (JAVA_AGENT_EMBED_DIR), matching OBI's Makefile convention, so local builds embed the real agent correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Beyla Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Fix: embed Java agent JAR at compile timeRoot causeThe new OBI version (14950c5) uses Files changed
Expected CI outcome
Upstream noteThe OBI |
Automated update of the OBI (OpenTelemetry eBPF Instrumentation) submodule to the latest commit from grafana/opentelemetry-ebpf-instrumentation main.
OBI commit:
14950c5If CI fails due to upstream breaking changes, add the agent/fix-obi label to this PR to run the agentic workflow and get suggested fixes.