agent/fix-obi: sync tests to OBI upstream before patching assertions#2560
Merged
rafaelroquetto merged 1 commit intomainfrom Feb 28, 2026
Merged
agent/fix-obi: sync tests to OBI upstream before patching assertions#2560rafaelroquetto merged 1 commit intomainfrom
rafaelroquetto merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix-obiagent workflowContext
When an OBI commit removes a feature/option, its test block is also removed upstream. Previously, the plan agent could see a failing Beyla assertion and produce a plan to adjust it (e.g.
assert.False(...)) — technically making it green, but diverging from upstream intent.The new rule instructs the agent to first locate the same test in
.obi-src/, compare the failing block against the OBI version, and:Example that motivated this change
TestWillUseTCin Beyla'sconfig_test.go— OBI removed the"ip"sub-case inopen-telemetry/opentelemetry-ebpf-instrumentation@56db2407, but the agent patchedthe assertion instead of removing the block.