Skip to content

Fix sql docs#2465

Merged
grcevski merged 1 commit intomainfrom
fix_sql_docs
Jan 28, 2026
Merged

Fix sql docs#2465
grcevski merged 1 commit intomainfrom
fix_sql_docs

Conversation

@marctc
Copy link
Contributor

@marctc marctc commented Jan 28, 2026

  • Removed instaces of sql.client.duration and redis.client.duration
  • Link to semantic conventions for metric attributes.
  • Example of filtering per db.system.name

fixes #1190

@marctc marctc requested a review from a team as a code owner January 28, 2026 13:16
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 28, 2026
View reviewed changes
docs/sources/cardinality.md Outdated
* Backend as a RPC server
* `rpc.server.duration`
* Backend as an SQL and HTTP client
* Backend as a SQL and HTTP client

Check warning

Code scanning / Vale

Use 'an SQL' instead of 'a SQL'. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/#sql-structured-query-language. To fix this, Replace the matched content with one of the following: - `an SQL`.

Use 'an SQL' instead of 'a SQL'. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/#sql-structured-query-language. To fix this, Replace the matched content with one of the following: - `an SQL`.
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.78%. Comparing base (a6c2403) to head (5fc4a73).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2465      +/-   ##
==========================================
- Coverage   50.76%   46.78%   -3.98%     
==========================================
  Files          48       48              
  Lines        4003     4003              
==========================================
- Hits         2032     1873     -159     
- Misses       1811     1997     +186     
+ Partials      160      133      -27
Flag Coverage Δ
integration-test ?
integration-test-vm-${ARCH}-${KERNEL_VERSION} ?
k8s-integration-test ?
oats-test ?
unittests 46.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

grcevski
grcevski approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit d2b01cc into main Jan 28, 2026
18 checks passed
@grcevski grcevski deleted the fix_sql_docs branch January 28, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grcevski grcevski grcevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document better all available attributes for filtering

3 participants

@marctc @codecov-commenter @grcevski