Skip to content

More type checks in helm chart#2373

Merged
mariomac merged 4 commits intografana:mainfrom
mariomac:helm-more-type-checks
Dec 12, 2025
Merged

More type checks in helm chart#2373
mariomac merged 4 commits intografana:mainfrom
mariomac:helm-more-type-checks

Conversation

@mariomac
Copy link
Contributor

Fixes this error in some helm versions:

Error: template: beyla/templates/daemon-set.yaml:89:21: executing "beyla/templates/daemon-set.yaml" at <ne .Values.config.data.internal_metrics.prometheus.port 0>: error calling ne: incompatible types for comparison Use --debug flag to render out invalid YAML

@mariomac mariomac requested a review from a team as a code owner December 12, 2025 09:22
name: beyla
version: 1.10.1
version: 1.10.2
appVersion: 2.7.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump to 2.8.1?

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.43%. Comparing base (055449a) to head (2fa0a9b).

❗ There is a different number of reports uploaded between BASE (055449a) and HEAD (2fa0a9b). Click for more details.

HEAD has 37 uploads less than BASE
Flag BASE (055449a) HEAD (2fa0a9b)
oats-test 5 0
integration-test-vm-${ARCH}-${KERNEL_VERSION} 6 0
k8s-integration-test 16 0
integration-test 10 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2373      +/-   ##
==========================================
- Coverage   48.94%   43.43%   -5.51%     
==========================================
  Files          39       39              
  Lines        2977     2977              
==========================================
- Hits         1457     1293     -164     
- Misses       1379     1571     +192     
+ Partials      141      113      -28     
Flag Coverage Δ
integration-test ?
integration-test-vm-${ARCH}-${KERNEL_VERSION} ?
k8s-integration-test ?
oats-test ?
unittests 43.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariomac mariomac merged commit 9b1347d into grafana:main Dec 12, 2025
13 checks passed
@mariomac mariomac deleted the helm-more-type-checks branch December 12, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants