Helm: fix prometheus port set to 0#2371
Merged
mariomac merged 1 commit intografana:mainfrom Dec 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
- Coverage 49.78% 43.25% -6.53%
==========================================
Files 38 38
Lines 2971 2971
==========================================
- Hits 1479 1285 -194
- Misses 1343 1573 +230
+ Partials 149 113 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marctc
approved these changes
Dec 11, 2025
Contributor
|
idea: at some point we could stole some of the linters and testing used here https://github.com/grafana/k8s-monitoring-helm/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a breaking change in Helm (zero values are now treated as existing), people trying to disable prometheus port by setting it to 0 caused an error: