fix: Database_observability: reuse cloud provider regexes#5262
Merged
cristiangreco merged 1 commit intomainfrom Jan 14, 2026
Merged
fix: Database_observability: reuse cloud provider regexes#5262cristiangreco merged 1 commit intomainfrom
cristiangreco merged 1 commit intomainfrom
Conversation
Consolidate the regexes in a common package and make sure to support Azure privatelink parsing.
matthewnolf
approved these changes
Jan 14, 2026
| ) | ||
|
|
||
| var ( | ||
| RdsRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`) |
Contributor
There was a problem hiding this comment.
Suggested change
| RdsRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`) | |
| RDSRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Consolidate the regexes in a common package and make sure to support Azure privatelink parsing.
Pull Request Details
This is a followup of #5260
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist