Merged
Conversation
Contributor
|
💻 Deploy preview deleted. |
kgeckhart
approved these changes
Sep 5, 2025
Contributor
kgeckhart
left a comment
There was a problem hiding this comment.
Thank you for this one!
clayton-cornell
approved these changes
Sep 8, 2025
c209ac2 to
dfae383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
In dogfooding clusters we tend to set
send_batch_size/send_batch_max_sizeat 1800/2000, and even at 400/500 in some cases (to avoid really large spans). I think setting the default values at 2000 and 3000 should be totally ok and won't lead to issues.Users with a poor network they might prefer to send larger batches, but even then they might hit the limit of what the DB allows them to send. For most users 2000/3000 should be ok.
In theory the defaults could be brought down even more. But I'm not sure by how much, and also there's no point pondering about the defaults for the batch processor much right now. It is going to be EOL soon and we need to focus on getting the defaults right for the new
batchblocks in the exporter config.Which issue(s) this PR fixes
Fixes #4000
PR Checklist